Webforms URL Broken after upgrade

[covarrubiasgg]

Hey this is just FYI

This weekend we upgrade from Vicidial 2.12 to VERSION: 2.14-628a BUILD: 170913-0908 via SVN update. Everything seems to work fine as usual, except that the WEBFORM which i had in a format like

VARhttp://pathtocrm/interview/create?na ... email--B--

started passing "var" into the url and wasn't passing any variables it was like this:

varhttp://pathtocrm/interview/create?na ... ne=&email=

As soon as i removed VAR from the URL it started working (after 30 minutes of trying to figure out what was wrong).

It is a minor issue, but if it is no longer require, it is still shown as required in the inline help, that was what drove me crazy

[mflorell]

If you don't put VAR, it will not parse for --A-- field flags, and it will instead output all of them with their default field labels.

[covarrubiasgg]

well VAR is not working on that specific BUILD.

We have been using that system since 2011 with regular upgrades, this is the first time we have this issue.

If there is any specific test that i can run, just let me know,

But this is how it behaves

config: http://192.168.100.110/leads/viewleadbyphone/--A--phone_number--B--
result: http://192.168.100.110/leads/viewleadbyphone/XXXXXXXX?lead_id=XXXXXXX&vendor_id=XXXXXX&list_id=XXXXX&gmt_offset_now=-7.00&phone_code=1&phone_number=XXXXXXX&title=&first_name=&middle_initial=&last_name=&address1=&address2=&address3=&city=&state=&province=&postal_code=&country_code=&gender=U&date_of_birth=0000-00-00&alt_phone=&email=&security_phrase=XXXXXX&comments=XXXXXXXX&user=XXXXXX&pass=XXXXXX&orig_pass=XXXXX&campaign=XXXXXX&phone_login=XXXXX&original_phone_login=XXXXX&phone_pass=XXXXXX&fronter=XXXXXX&closer=XXXXXX&group=XXXXXX&channel_group=XXXXXX&SQLdate=2017-09-20+234649&epoch=1505976409&uniqueid=&customer_zap_channel=&customer_server_ip=&server_ip=XXXXXXX&SIPexten=XXXX&session_id=XXXXXX&phone=XXXXX&parked_by=XXXX&dispo=&dialed_number=XXXXXXX&dialed_label=MANUAL_DIALNOW&source_id=VDCL&rank=0&owner=c4tech&camp_script=&in_script=&script_width=896&script_height=404&fullname=XXXXXX&agent_email=&recording_filename=&recording_id=&user_custom_one=&user_custom_two=&user_custom_three=&user_custom_four=&user_custom_five=&preset_number_a=&preset_number_b=&preset_number_c=&preset_number_d=&preset_number_e=&preset_dtmf_a=&preset_dtmf_b=&did_id=&did_extension=&did_pattern=&did_description=&closecallid=&xfercallid=&agent_log_id=43830553&entry_list_id=999&call_id=M9202346500006081486&user_group=ADMIN&list_name=Default%20inbound%20list&list_description=&entry_date=2017-04-13+125625&did_custom_one=&did_custom_two=&did_custom_three=&did_custom_four=&did_custom_five=&called_count=28&web_vars=&session_name=1505976395_585812199108

config: VARhttp://192.168.100.110/leads/viewleadbyphone/--A--phone_number--B--
result: varhttp://192.168.100.110/leads/viewleadbyphone/?lead_id=XXXXXXX&vendor_id=XXXXXX&list_id=XXXXX&gmt_offset_now=-7.00&phone_code=1&phone_number=XXXXXXX&title=&first_name=&middle_initial=&last_name=&address1=&address2=&address3=&city=&state=&province=&postal_code=&country_code=&gender=U&date_of_birth=0000-00-00&alt_phone=&email=&security_phrase=XXXXXX&comments=XXXXXXXX&user=XXXXXX&pass=XXXXXX&orig_pass=XXXXX&campaign=XXXXXX&phone_login=XXXXX&original_phone_login=XXXXX&phone_pass=XXXXXX&fronter=XXXXXX&closer=XXXXXX&group=XXXXXX&channel_group=XXXXXX&SQLdate=2017-09-20+234649&epoch=1505976409&uniqueid=&customer_zap_channel=&customer_server_ip=&server_ip=XXXXXXX&SIPexten=XXXX&session_id=XXXXXX&phone=XXXXX&parked_by=XXXX&dispo=&dialed_number=XXXXXXX&dialed_label=MANUAL_DIALNOW&source_id=VDCL&rank=0&owner=c4tech&camp_script=&in_script=&script_width=896&script_height=404&fullname=XXXXXX&agent_email=&recording_filename=&recording_id=&user_custom_one=&user_custom_two=&user_custom_three=&user_custom_four=&user_custom_five=&preset_number_a=&preset_number_b=&preset_number_c=&preset_number_d=&preset_number_e=&preset_dtmf_a=&preset_dtmf_b=&did_id=&did_extension=&did_pattern=&did_description=&closecallid=&xfercallid=&agent_log_id=43830553&entry_list_id=999&call_id=M9202346500006081486&user_group=ADMIN&list_name=Default%20inbound%20list&list_description=&entry_date=2017-04-13+125625&did_custom_one=&did_custom_two=&did_custom_three=&did_custom_four=&did_custom_five=&called_count=28&web_vars=&session_name=1505976395_585812199108

So, without VAR it resolves the URL, it resolves de --A--variables--B-- and at the end it append the whole var set in default format

But if I use VAR, it appends "var" at the beginning of the url, it does not resolve the --A--variables--B-- and it also apprend the whole var set in default format, but since it has the "var" at the beginning, the webform never opens in a browser

Not big deal for me, but if I can help to solve anything tomorrow i will try to dig inside the changes in the code to spot anything wrong

[mflorell]

I just tested this on my development system and I can't replicate the issue, and I have never seen this issue on any client systems either, and we have several clients running on that version from last week. The replacement of "VAR" with "var" is very confusing since there doesn't seem to be anything in the code that does that. Do you ever see anything show up on your browser console related to this?