Page 1 of 1
semi-colon removed in settings containers
Posted:
Fri Nov 30, 2018 6:25 am
by dspaan
The documentation here
http://www.vicidial.org/docs/DISPO_SEND_EMAIL.txtsays:
A semi-colon ";" at the beginning of a line will comment out that line and it will not be parsed.
If i paste the example template in the documenation in a container and save all my semi-colon's are removed. Is this a bug?
I even tested this with Vicibox 8.1.2 and SVN 3053
Re: semi-colon removed in settings containers
Posted:
Fri Nov 30, 2018 10:13 am
by mflorell
I can't replicate this issue. Might this be a non-English-language only issue?
Re: semi-colon removed in settings containers
Posted:
Fri Nov 30, 2018 11:13 am
by dspaan
I tried without translation but the same happens.
Re: semi-colon removed in settings containers
Posted:
Fri Nov 30, 2018 5:20 pm
by mflorell
Not sure what the issue is then, because I can't replicate that issue on the 3 systems I've tried it on.
Re: semi-colon removed in settings containers
Posted:
Fri Nov 30, 2018 5:34 pm
by williamconley
mflorell wrote:I can't replicate this issue. Might this be a non-English-language only issue?
VERSION: 2.14-665a
BUILD: 180316-0751
I can't replicate it either. All semicolons survive "submit" and are still present if I go back and check later. But this is an older system than dspaan's.
Re: semi-colon removed in settings containers
Posted:
Fri Nov 30, 2018 5:55 pm
by blackbird2306
#MeTooSemicolonOk on same revision 3053 as dspaan. Try to add a new container with e.g only ;;;;;; in container entry and look if there is something (look also in db as well). There is no place, where $container_entry will be filtered. Might be a charset thing. Try another browser. This is the part where $container_entry will be written in db:
- Code: Select all
Line 17067: $stmt="UPDATE vicidial_settings_containers set container_notes='$container_notes',container_type='$container_type',user_group='$user_group',container_entry='" . mysqli_real_escape_string($link, $container_entry) ."' where container_id='$container_id';";
Re: semi-colon removed in settings containers
Posted:
Tue Dec 04, 2018 7:20 am
by dspaan
Sorry guys, my bad. Because of the translation i made a mistake and was pasting an e-mail template in the Templates section and not in the Containers. Case closed!
Re: semi-colon removed in settings containers
Posted:
Tue Dec 04, 2018 10:58 am
by williamconley
dspaan wrote:Sorry guys, my bad. Because of the translation i made a mistake and was pasting an e-mail template in the Templates section and not in the Containers. Case closed!
You either need more sleep or less caffeine. Maybe both.
Re: semi-colon removed in settings containers
Posted:
Tue Dec 04, 2018 1:41 pm
by dspaan
Trust me, our Nespresso machine is frequently used.