Page 1 of 1

HotKeys not always working

PostPosted: Fri May 16, 2008 4:29 pm
by i_magic
I am using 2.0.4rc1 and I tried this with Firefox 2.0.0.14 and IE 6

For some reason hot keys seem to be disabled in certain instances, eg:

-After I get disconnected number and hear doo-doo-doo, The number you have dialed..., I have hotkey set up to mark it a DC, I keep pressing it and it don't work. I have to click HANG UP CUSTOMER button and go via dispo screen

-Some numbers just ring forever and I would like to be able to go to the next number after 35 seconds, I have N (no answer) hotkey, but it doesn't work if the customer has not answered. If I hit the key after the customer has answered, it does work

It appears that hotkeys are only active when there is live call (person or answering machine).

Is this a bug or a feature? ;)

-TJ

PostPosted: Fri May 16, 2008 7:27 pm
by mflorell
Is this for Manual dial mode (dial level = 0)?

PostPosted: Fri May 16, 2008 7:30 pm
by i_magic
yep, manual dial

PostPosted: Sat May 17, 2008 12:55 am
by mflorell
OK, that is how the system is currently supposed to act with Manual Dial.

The issue is with the channel pointer, until you receive an Answer signal from the carrier the call does not have a valid channel pointer and that causes a level of extra complexity to the process of hanging up the call. It might be possible to change Hotkeys to work with pre-Answered calls, but I have not looked into how much effort that would take at this point since noone has made that feature a priority.

PostPosted: Sat May 17, 2008 10:54 am
by i_magic
I don't know much about internal workings of vici, but my immediate idea is to may be simulate: click HANG UP CUSTOMER, click-click dispo screen, click DIAL NEXT NUMBER.

In other words, collect up all of the code from routines behind above click-clicks and put them into one place (or call them from one place) after a hotkey is pressed.

Just my 2 cents...

-TJ

PostPosted: Sat May 17, 2008 6:51 pm
by i_magic
Matt, Could you give me a pointer where I should look for the relevant code. I am willing to do any needed hacking. (I haven't done php before, then again there is always a firts time. :) )

Thanks,
-TJ

PostPosted: Mon May 19, 2008 9:22 am
by mflorell
HotKeys is actually a fairly complex function that has actions all over the place in the vicidial.php code. It is mostly Javascript code.

I will put this in my list of things to do, but it is not a priority at the moment.

I would suggest going through the HotKeys and Hangup Customer functions and understand them before try to make changes. There are a lot of carefully order fonctions in there.