Feature Chg - vendor_lead_code field maxlength from 20 to 36

Discussions about new features or changes in existing features

Moderators: gerski, enjay, williamconley, Op3r, Staydog, gardo, mflorell, MJCoate, mcargile, Kumba, Michael_N

Feature Chg - vendor_lead_code field maxlength from 20 to 36

Postby TroyD » Thu May 22, 2014 1:00 am

I notice that a lot of folks are using the dialer with crm. Most electing an open source solution like Vtiger or Sugar, usually after svn updates etc, I have to modify the vicidial.php to change the maxlength for the vendor_lead_code to 36 from 20 so it will support a standard guid. I have previously also altered the length in MySQL to accommodate the larger field size. Would it be too much of an issue to increase from 20 to 36 in subsequent versions? Just curious, its not a big issue but curious if it would make it easier going forward for a lot of users.?
|3 Server - Cluster - WEB/DB/DIALER - ViciBox Install
|ASTERISK VER - Asterisk 11.25.1-vici
|AstGuiClient VERSION: 2.14-678a
|BUILD: 180613-0943
TroyD
 
Posts: 96
Joined: Fri Nov 02, 2007 4:03 pm

Re: Feature Chg - vendor_lead_code field maxlength from 20 t

Postby mflorell » Thu May 22, 2014 7:06 am

Since it is a VARCHAR it shouldn't have much effect on speed or space used to make it a little bigger. Please create a new Issue Tracker ticket and link to it here and we will look into it.
mflorell
Site Admin
 
Posts: 18387
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Re: Feature Chg - vendor_lead_code field maxlength from 20 t

Postby mflorell » Mon Nov 24, 2014 4:10 pm

Since the vendor_lead_code field is present in the vicidial_hopper table(which is a memory table) we are not going to change this in our default settings. MEMORY tables cannot use VARCHAR fields, and must allocate all of the memory even if the field is empty. You could certainly make this modification on your system, but we aren't going to lengthen this field by default at this time.

Here's how you would do this on your system in MySQL:

ALTER TABLE vicidial_list MODIFY vendor_lead_code VARCHAR(36);
ALTER TABLE vicidial_hopper MODIFY vendor_lead_code VARCHAR(36) default '';

Referenced,
http://www.vicidial.org/VICIDIALmantis/view.php?id=766
mflorell
Site Admin
 
Posts: 18387
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida


Return to Features

Who is online

Users browsing this forum: No registered users and 15 guests