team performance detail not showing sales correctly

[williamconley]

find the sql query that stores it in the vicidial.php script ... and put lower(field_name) instead of field_name ... that's the simple mysql command to convert when the data is written. and post your solution in the vicidial issue tracker (and link to it here) so it can be fixed in svn

[DomeDan]

Might be more logs that gets written to, so I would say its better to make it lower case in the beginning of the scripts. "$VD_login=strtolower($VD_login);"

Code: Select all

domedan@host:~$ cd www/agc
domedan@host:www/agc$ grep '\"\",\$VD_login);' ./*.php
./phone_only.php:$VD_login=preg_replace("/[^-_0-9a-zA-Z]/","",$VD_login);
./timeclock.php:   $VD_login=preg_replace("/[^0-9a-zA-Z]/","",$VD_login);
./vicidial.php:$VD_login=preg_replace("/[^-_0-9a-zA-Z]/","",$VD_login);

domedan@host:www/agc$ sed -i 's/\"\",\$VD_login);/\"\",\$VD_login);\n\$VD_login=strtolower(\$VD_login);/g' ./*.php

tested briefly.

Same problem will probably happen in the admin interface, have not tested this:

Code: Select all

domedan@host:~$ cd www/vicidial
domedan@host:www/vicidial$ grep "'',\$PHP_AUTH_USER);" ./*.php
domedan@host:www/vicidial$ sed -i "s/'',\$PHP_AUTH_USER);/'',\$PHP_AUTH_USER);\n\t\$PHP_AUTH_USER = strtolower(\$PHP_AUTH_USER);/g" ./*.php

[nrc]

Thanks Domedan,

I will try this tonight, and see how it goes tomorrow!

[nrc]

That did it DomeDan!

Thanks so much!

[DomeDan]

Nice!

There is several ways to prevent this from happening again, like:
* force only numeric user id
* make the scripts get the user id value from the database instead of the user input
* edit the user-add code to make it upper or lower as default
* edit the vicidial login to force the user id login to be exactly the same as the database entry Rxv==Rxv
* only join tables and stuff with the real user_id which is a auto increment value in vicidial_users

I don't know which one would be best

[nrc]

I'm not sure either...but maybe Matt and his team can come up with something

[mflorell]

If you create an Issue Tracker ticket and post a link to it here we will be able to take a look at it the next time we go through there fixing things.

[DomeDan]

http://www.vicidial.org/VICIDIALmantis/view.php?id=682

[DomeDan]

nrc:
Matt has added a function to prevent the uppercase issue:
http://www.vicidial.org/VICIDIALmantis/view.php?id=682
"Based upon some client feedback, I have added a case-sensitive validation to the agent login process. If the user/pass are correct but the case of the user is wrong it will fail login but it will show a message "Login incorrect, user names are case sensitive".
This change has been committed to svn/trunk. Please let me know if you have any feedback."
If you are still active then try it out