semi-colon removed in settings containers

All installation and configuration problems and questions

Moderators: gerski, enjay, williamconley, Op3r, Staydog, gardo, mflorell, MJCoate, mcargile, Kumba, Michael_N

semi-colon removed in settings containers

Postby dspaan » Fri Nov 30, 2018 6:25 am

The documentation here http://www.vicidial.org/docs/DISPO_SEND_EMAIL.txt

says:

A semi-colon ";" at the beginning of a line will comment out that line and it will not be parsed.


If i paste the example template in the documenation in a container and save all my semi-colon's are removed. Is this a bug?

I even tested this with Vicibox 8.1.2 and SVN 3053
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1377
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Re: semi-colon removed in settings containers

Postby mflorell » Fri Nov 30, 2018 10:13 am

I can't replicate this issue. Might this be a non-English-language only issue?
mflorell
Site Admin
 
Posts: 18384
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Re: semi-colon removed in settings containers

Postby dspaan » Fri Nov 30, 2018 11:13 am

I tried without translation but the same happens.
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1377
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Re: semi-colon removed in settings containers

Postby mflorell » Fri Nov 30, 2018 5:20 pm

Not sure what the issue is then, because I can't replicate that issue on the 3 systems I've tried it on.
mflorell
Site Admin
 
Posts: 18384
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Re: semi-colon removed in settings containers

Postby williamconley » Fri Nov 30, 2018 5:34 pm

mflorell wrote:I can't replicate this issue. Might this be a non-English-language only issue?

VERSION: 2.14-665a
BUILD: 180316-0751

I can't replicate it either. All semicolons survive "submit" and are still present if I go back and check later. But this is an older system than dspaan's.
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20258
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Re: semi-colon removed in settings containers

Postby blackbird2306 » Fri Nov 30, 2018 5:55 pm

#MeTooSemicolonOk on same revision 3053 as dspaan. Try to add a new container with e.g only ;;;;;; in container entry and look if there is something (look also in db as well). There is no place, where $container_entry will be filtered. Might be a charset thing. Try another browser. This is the part where $container_entry will be written in db:
Code: Select all
Line 17067: $stmt="UPDATE vicidial_settings_containers set container_notes='$container_notes',container_type='$container_type',user_group='$user_group',container_entry='" . mysqli_real_escape_string($link, $container_entry) ."' where container_id='$container_id';";
Vicibox 6.0.2 from Vicibox_v.6.0.x86_64-6.0.2.iso | Vicidial 2.12-560a build: 160617-1427 | Asterisk 1.8.32.3
blackbird2306
 
Posts: 409
Joined: Mon Jun 23, 2014 5:31 pm

Re: semi-colon removed in settings containers

Postby dspaan » Tue Dec 04, 2018 7:20 am

Sorry guys, my bad. Because of the translation i made a mistake and was pasting an e-mail template in the Templates section and not in the Containers. Case closed!
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1377
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands

Re: semi-colon removed in settings containers

Postby williamconley » Tue Dec 04, 2018 10:58 am

dspaan wrote:Sorry guys, my bad. Because of the translation i made a mistake and was pasting an e-mail template in the Templates section and not in the Containers. Case closed!

You either need more sleep or less caffeine. Maybe both. 8-)
Vicidial Installation and Repair, plus Hosting and Colocation
Newest Product: Vicidial Agent Only Beep - Beta
http://www.PoundTeam.com # 352-269-0000 # +44(203) 769-2294
williamconley
 
Posts: 20258
Joined: Wed Oct 31, 2007 4:17 pm
Location: Davenport, FL (By Disney!)

Re: semi-colon removed in settings containers

Postby dspaan » Tue Dec 04, 2018 1:41 pm

Trust me, our Nespresso machine is frequently used.
Regards, Dennis

Vicibox 9.0.1
Version: 2.14b0.5
SVN Version: 3199
DB Schema Version: 1588
Build: 200310-1801
dspaan
 
Posts: 1377
Joined: Fri Aug 21, 2009 1:40 pm
Location: The Netherlands


Return to Support

Who is online

Users browsing this forum: Google [Bot], Google Feedfetcher and 100 guests